logo
Free, unlimited AI code reviews that run on commit
git-lrc git-lrc GitHub Install Now We'd appreciate a star git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt

Perl::Critic::Policy::ControlStructures::ProhibitUnreachableCode - Don't write code after an

Affiliation

       This Policy is part of the core Perl::Critic distribution.

Author

       Peter Guzis <pguzis@cpan.org>

Configuration

       This Policy is not configurable except for the standard options.

Description

       This policy prohibits code following a statement which unconditionally alters the program flow.  This
       includes calls to "exit", "die", "return", "next", "last" and "goto".  Due to common usage, "croak" and
       "confess" from Carp are also included.

       Code is reachable if any of the following conditions are true:

       •   Flow-altering statement has a conditional attached to it

       •   Statement is on the right side of an operator "&&", "||", "//", "and", "or", or "err".

       •   Code is prefixed with a label (can potentially be reached via "goto")

       •   Code is a subroutine

Examples

         # not ok

         exit;
         print "123\n";

         # ok

         exit if !$xyz;
         print "123\n";

         # not ok

         for ( 1 .. 10 ) {
             next;
             print 1;
         }

         # ok

         for ( 1 .. 10 ) {
             next if $_ == 5;
             print 1;
         }

         # not ok

         sub foo {
             my $bar = shift;
             return;
             print 1;
         }

         # ok

         sub foo {
             my $bar = shift;
             return if $bar->baz();
             print 1;
         }

         # not ok

         die;
         print "123\n";

         # ok

         die;
         LABEL: print "123\n";

         # not ok

         croak;
         do_something();

         # ok

         croak;
         sub do_something {}

Name

       Perl::Critic::Policy::ControlStructures::ProhibitUnreachableCode - Don't write code after an
       unconditional "die, exit, or next".

See Also

       Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls

See Also