logo
Free, unlimited AI code reviews that run on commit
git-lrc git-lrc GitHub Install Now We'd appreciate a star git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt

Perl::Critic::Policy::RegularExpressions::RequireExtendedFormatting - Always use the "/x" modifier with

Affiliation

       This Policy is part of the core Perl::Critic distribution.

Author

       Jeffrey Ryan Thalhammer  <jeff@imaginative-software.com>

Configuration

       You might find that putting a "/x" on short regular expressions to be excessive.  An exception can be
       made for them by setting "minimum_regex_length_to_complain_about" to the minimum match length you'll
       allow without a "/x".  The length only counts the regular expression, not the braces or operators.

           [RegularExpressions::RequireExtendedFormatting]
           minimum_regex_length_to_complain_about = 5

           $num =~ m<(\d+)>;              # ok, only 5 characters
           $num =~ m<\d\.(\d+)>;          # not ok, 9 characters

       This option defaults to 0.

       Because using "/x" on a regex which has whitespace in it can make it harder to read (you have to escape
       all that innocent whitespace), by default, you can have a regular expression that only contains
       whitespace and word characters without the modifier.  If you want to restrict this, turn on the "strict"
       option.

           [RegularExpressions::RequireExtendedFormatting]
           strict = 1

           $string =~ m/Basset hounds got long ears/;  # no longer ok

       This option defaults to false.

Description

       Extended regular expression formatting allows you mix whitespace and comments into the pattern, thus
       making them much more readable.

           # Match a single-quoted string efficiently...

           m{'[^\\']*(?:\\.[^\\']*)*'};  #Huh?

           # Same thing with extended format...

           m{
               '           # an opening single quote
               [^\\']      # any non-special chars (i.e. not backslash or single quote)
               (?:         # then all of...
                   \\ .    #    any explicitly backslashed char
                   [^\\']* #    followed by a non-special char
               )*          # ...repeated zero or more times
               '           # a closing single quote
           }x;

Name

       Perl::Critic::Policy::RegularExpressions::RequireExtendedFormatting - Always use the "/x" modifier with
       regular expressions.

Notes

       For common regular expressions like e-mail addresses, phone numbers, dates, etc., have a look at the
       Regexp::Common module.  Also, be cautions about slapping modifier flags onto existing regular
       expressions, as they can drastically alter their meaning.  See <http://www.perlmonks.org/?node_id=484238>
       for an interesting discussion on the effects of blindly modifying regular expression flags.

To Do

       Add an exemption for regular expressions that contain "\Q" at the front and don't use "\E" until the very
       end, if at all.

See Also