logo
Free, unlimited AI code reviews that run on commit
git-lrc git-lrc GitHub Install Now We'd appreciate a star git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt

Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock - Forbid $b before $a in sort blocks.

Affiliation

       This Policy is part of the core Perl::Critic distribution.

Author

       Chris Dolan <cdolan@cpan.org>

Configuration

       This Policy is not configurable except for the standard options.

Description

       Conway says that it is much clearer to use "reverse" than to flip $a and $b around in a "sort" block.  He
       also suggests that, in newer perls, "reverse" is specifically looked for and optimized, and in the case
       of a simple reversed string "sort", using "reverse" with a "sort" with no block is faster even in old
       perls.

           my @foo = sort { $b cmp $a } @bar;         #not ok
           my @foo = reverse sort @bar;               #ok

           my @foo = sort { $b <=> $a } @bar;         #not ok
           my @foo = reverse sort { $a <=> $b } @bar; #ok

Name

       Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock - Forbid $b before $a in sort blocks.

See Also