logo
Free, unlimited AI code reviews that run on commit
git-lrc git-lrc GitHub Install Now We'd appreciate a star git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt

Perl::Critic::Policy::BuiltinFunctions::RequireSimpleSortBlock - Sort blocks should have a single

Affiliation

       This Policy is part of the core Perl::Critic distribution.

Author

       Chris Dolan <cdolan@cpan.org>

Configuration

       This Policy is not configurable except for the standard options.

Description

       Conway advises that sort functions should be simple.  Any complicated operations on list elements should
       be computed and cached (perhaps via a Schwartzian Transform) before the sort, rather than computed inside
       the sort block, because the sort block is called "N log N" times instead of just "N" times.

       This policy prohibits the most blatant case of complicated sort blocks: multiple statements.  Future
       policies may wish to examine the sort block in more detail -- looking for subroutine calls or large
       numbers of operations.

Name

       Perl::Critic::Policy::BuiltinFunctions::RequireSimpleSortBlock - Sort blocks should have a single
       statement.

See Also