logo
Free, unlimited AI code reviews that run on commit
git-lrc git-lrc GitHub Install Now We'd appreciate a star git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt

Perl::Critic::Policy::Variables::ProhibitLoopOnHash - Don't write loops on hashes, only on keys and

Author

       Sawyer X

Configuration

       This policy is not configurable except for the standard options.

Description

       When "looping over hashes," we mean looping over hash keys or hash values. If you forgot to call "keys"
       or "values" you will accidentally loop over both.

           foreach my $foo (%hash) {...}        # not ok
           action() for %hash;                  # not ok
           foreach my $foo ( keys %hash ) {...} # ok
           action() for values %hash;           # ok

       An effort is made to detect expressions:

           action() for %hash ? keys %hash : ();                             # ok
           action() for %{ $hash{'stuff'} } ? keys %{ $hash{'stuff'} } : (); # ok

       (Granted, the second example there doesn't make much sense, but I have found a variation of it in real
       code.)

Name

       Perl::Critic::Policy::Variables::ProhibitLoopOnHash - Don't write loops on hashes, only on keys and
       values of hashes

See Also

       Perl::Critic

Thanks

       Thank you to Ruud H.G. Van Tol.

Version

       version 0.008

See Also