logo
Free, unlimited AI code reviews that run on commit
git-lrc git-lrc GitHub Install Now We'd appreciate a star git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt

Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations - Do not write " my $foo = $bar if $baz;

Affiliation

       This Policy is part of the core Perl::Critic distribution.

Author

       Jeffrey R. Thalhammer <jeff@imaginative-software.com>

Configuration

       This Policy is not configurable except for the standard options.

Description

       Declaring a variable with a postfix conditional is really confusing.  If the conditional is false, its
       not clear if the variable will be false, undefined, undeclared, or what.  It's much more straightforward
       to make variable declarations separately.

           my $foo = $baz if $bar;          #not ok
           my $foo = $baz unless $bar;      #not ok
           our $foo = $baz for @list;       #not ok
           local $foo = $baz foreach @list; #not ok

Name

       Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations - Do not write " my $foo = $bar if $baz;
       ".

See Also