logo
Free, unlimited AI code reviews that run on commit
git-lrc git-lrc GitHub Install Now We'd appreciate a star git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt

Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit - Write "split /-/, $string" instead of

Affiliation

       This Policy is part of the core Perl::Critic distribution.

Author

       Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>

Configuration

       This Policy is not configurable except for the standard options.

Description

       The "split" function always interprets the PATTERN argument as a regular expression, even if you specify
       it as a string.  This causes much confusion if the string contains regex metacharacters.  So for clarity,
       always express the PATTERN argument as a regex.

           $string = 'Fred|Barney';
           @names = split '|', $string; #not ok, is ('F', 'r', 'e', 'd', '|', 'B', 'a' ...)
           @names = split m/[|]/, $string; #ok, is ('Fred', Barney')

       When the PATTERN is a single space the "split" function has special behavior, so Perl::Critic forgives
       that usage.  See "perldoc -f split" for more information.

Name

       Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit - Write "split /-/, $string" instead of
       "split '-', $string".

See Also

       Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep

       Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap

See Also