logo
Free, unlimited AI code reviews that run on commit
git-lrc git-lrc GitHub Install Now We'd appreciate a star git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt

Perl::Critic::Policy::Modules::ProhibitAutomaticExportation - Export symbols via "@EXPORT_OK" or

Affiliation

       This Policy is part of the core Perl::Critic distribution.

Author

       Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>

Configuration

       This Policy is not configurable except for the standard options.

Description

       When using Exporter, symbols placed in the @EXPORT variable are automatically exported into the caller's
       namespace.  Although convenient, this practice is not polite, and may cause serious problems if the
       caller declares the same symbols.  The best practice is to place your symbols in @EXPORT_OK or
       %EXPORT_TAGS and let the caller choose exactly which symbols to export.

           package Foo;

           use Exporter 'import';
           our @EXPORT      = qw(foo $bar @baz);                  # not ok
           our @EXPORT_OK   = qw(foo $bar @baz);                  # ok
           our %EXPORT_TAGS = ( all => [ qw(foo $bar @baz) ] );   # ok

Name

       Perl::Critic::Policy::Modules::ProhibitAutomaticExportation - Export symbols via "@EXPORT_OK" or
       "%EXPORT_TAGS" instead of "@EXPORT".

See Also