logo
Free, unlimited AI code reviews that run on commit
git-lrc git-lrc GitHub Install Now We'd appreciate a star git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt git-lrc - Free, unlimited AI code reviews that run on commit | Product Hunt

Perl::Critic::Policy::Variables::RequireInitializationForLocalVars - Write "local $foo = $bar;" instead

Affiliation

       This Policy is part of the core Perl::Critic distribution.

Author

       Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>

Configuration

       This Policy is not configurable except for the standard options.

Description

       Most people don't realize that a localized copy of a variable does not retain its original value.  Unless
       you initialize the variable when you "local"-ize it, it defaults to "undef".  If you want the variable to
       retain its original value, just initialize it to itself.  If you really do want the localized copy to be
       undef, then make it explicit.

           package Foo;
           $Bar = '42';

           package Baz;

           sub frobulate {

               local $Foo::Bar;              #not ok, local $Foo::Bar is 'undef'
               local $Foo::Bar = undef;      #ok, local $Foo::Bar is obviously 'undef'
               local $Foo::Bar = $Foo::Bar;  #ok, local $Foo::Bar still equals '42'

           }

Name

       Perl::Critic::Policy::Variables::RequireInitializationForLocalVars - Write "local $foo = $bar;" instead
       of just "local $foo;".

See Also